contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts
https://py.contrails.org/
Apache License 2.0
59 stars 17 forks source link

Enable file locks in `MetDataSource.open_dataset` #213

Closed thabbott closed 4 months ago

thabbott commented 4 months ago

Changes

These changes prevent segmentation faults when reading and writing multi-file datasets with recent netCDF4 versions (see https://github.com/contrailcirrus/pycontrails/pull/204) and allow us to remove upper limits on netCDF4 and numpy versions.

These changes revert a change (https://github.com/contrailcirrus/pycontrails/pull/68) made to address the issue described in https://github.com/pydata/xarray/issues/4406. That issue remains open, so this change may resurface problems with dask threadlocks.

Breaking changes

Internals

Tests

Reviewer

@zebengberg