Fix/cds beta - Githubissues

contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts

https://py.contrails.org/

Apache License 2.0

59 stars 17 forks source link

Fix/cds beta #234

Closed zebengberg closed 3 months ago

zebengberg commented 3 months ago

Closes #232

Changes

Support ERA5 downloads from CDS-Beta. The updated interface is backwards compatible with the legacy CDS server. The choice of CDS server is governed by the url parameter in the ERA5 constructor.

Tests

[x] QC test passes locally (make test)
[x] CI tests pass

review-notebook-app[bot] commented 3 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mlshapiro commented 3 months ago

e.g. in https://github.com/contrailcirrus/pycontrails/pull/234/files#diff-20f55b0c90f463992ace406883ec3327b79c7b4325df6d58e9ffec729395e8e7L84

zebengberg commented 3 months ago

Thanks for fixing, maybe just add in the documentation the urls for the new/old CDS servers?

22cb17714f2fa69ce5fa414756878bb3994540d7