contrary-cat / LocalTVExtras.bundle

Local TV Extras Agent for Plex
82 stars 9 forks source link

Extras fail to populate, depending on the name of the show directory #9

Closed mikansoro closed 4 years ago

mikansoro commented 4 years ago

Issue Description:

I came across an issue in the most recent build of the agent (perhaps it's existed for a while, I just started using it), that causes extras to fail to be added to plex depending on the directory name of the show directory. I have only managed to make it happen to one directoy name in particular, but it is repeatable, hence this issue.

AniDB for Mirai no Mirai

Replication Steps:

If the show directory is named Mirai no Mirai, extras will fail to appear on a metadata refresh, and will disappear if they are currently displayed.

If the show directory is named Mirai, the extras will appear/reappear on a metadata refresh and play properly.

Other Agents/Notes

Screenshots

(These are taken from a windows machine with a mapped drive, the log is from Plex running on macos using a mapped SMB share)

Show Directory: image

Trailers Directory: image

Plex (Working, when show directory is named Mirai): image

Plex (Not working as intended, when show directory is named Mirai no Mirai): image

Logfile

Fresh Log File, where I change the name of the directory to Mirai no Mirai, rescan the library and extras disappear, then rename the directory to Mirai, rescan the library and extras are picked up by a metadata refresh: com.plexapp.agents.localtvextras.log

contrary-cat commented 4 years ago

This problem is caused because the agent is really designed to work for the standard Plex scanners, and not any 3rd party ones.

When your directory name is "Mirai no Mirai" it is exactly the same text as the "episode" filename - in that case, the agent assumes that it is in a specific episode subfolder. This means that the assumed show folder that it searches in is actually your anime directory and not the real show folder.

If your episode was named "Mirai no Mirai - S01E01", then the agent would work properly. In fact any difference between the names of the folder and the file should allow for it to work.

At the moment, the extras you have are being added - it's just that they are attached to the episode instead of the show. So if you switch the "Assign Extras to Episodes, Seasons or Shows based on folder structure" agent setting to false, then the extras would show up (although the agent would still misread the folder structure).

If you want to edit your own copy of the agent to remove the episode name = directory name checks, instead of changing the file or folder names, then I think commenting out or removing lines 164 to 167 should do it.

mikansoro commented 4 years ago

Gotcha. Thought it could've been a bug. I can work around the check behavior for my needs and if it eventually becomes an issue for me, I'll remove the directory checks myself.

Thanks.