src:arduino-timer: Remove WProgram.h include

contrem / arduino-timer

Non-blocking library for delaying function calls

BSD 3-Clause "New" or "Revised" License

334 stars 50 forks source link

src:arduino-timer: Remove WProgram.h include #23

Closed skrobinson closed 1 year ago

skrobinson commented 3 years ago

This header was renamed in Nov. 2011 and only Arduino IDE versions prior to v1.0 used that name.

Signed-off-by: Sean Robinson sean.robinson@scottsdalecc.edu

contrem commented 3 years ago

Thanks for your contribution. I'm going to leave this open for a while for visibility.

I'm aware of people using the library outside of the Arduino IDE, and don't know how this change may affect them. This might have to wait until the next major version bump.

skrobinson commented 3 years ago

Yes, I found this issue when building with a Makefile that does not have the ARDUINO define. While fixing the compile error, I realized the WProgram.h header was not relevant to a recent project and removed the version check, instead.

This may be enough of a change for others that it makes sense to hold off until 3.0.

contrem commented 1 year ago

included in release 3.0.0