search

contribsys / faktory

Language-agnostic persistent background job server
https://contribsys.com/faktory/
Other
5.73k stars 227 forks source link

Update client_windows.go #345

Closed christopherdiehl closed 3 years ago

christopherdiehl commented 3 years ago

Set package name so binaries built with go mod can build the project.

mperham commented 3 years ago

Thank you!

christopherdiehl commented 3 years ago

@mperham is it possible to cut a new patch release to allow go mod users to build and use the client?

mperham commented 3 years ago

Too minor for a new version. I've force updated the v1.5.0 tag to include this fix.

christopherdiehl commented 3 years ago

Thank you @mperham . It looks like v1.5.0 is still including the older version of client_windows.go.

mperham commented 3 years ago

I can't explain what you are seeing but the v1.5.0 tag on GitHub contains the fix. https://github.com/contribsys/faktory/blob/v1.5.0/client/client_windows.go

I suspect you need to clear go mod's cache for v1.5.0.

christopherdiehl commented 3 years ago

Looks like the release @ https://github.com/contribsys/faktory/releases is still the old version which is why I am still experiencing failures locally.

mperham commented 3 years ago

Yeah, I guess me manually overriding the tag does not regenerate the tarballs. I don’t know how to fix this. Can you pull a master or SHA tarball? Can you shallow clone the repo at the tag?

On Fri, Apr 9, 2021 at 08:42 Christopher Diehl @.***> wrote:

Looks like the release @ https://github.com/contribsys/faktory/releases is still the old version which is why I am still experiencing failures locally.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/contribsys/faktory/pull/345#issuecomment-816772555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAWX66V2Q46EQMPRUCDODTH4N7DANCNFSM42TTYG3A .

christopherdiehl commented 3 years ago

Unfortunately since we’re using bazel/go mod under the hood I haven’t been able to discover a solution that does not involve either updating the release tarballs or cutting a release.

Please let me know if there is anything I can do on my side to help!

On Fri, Apr 9, 2021 at 12:20 PM Mike Perham @.***> wrote:

Yeah, I guess me manually overriding the tag does not regenerate the tarballs. I don’t know how to fix this. Can you pull a master or SHA tarball? Can you shallow clone the repo at the tag?

On Fri, Apr 9, 2021 at 08:42 Christopher Diehl @.***> wrote:

Looks like the release @ https://github.com/contribsys/faktory/releases is still the old version which is why I am still experiencing failures locally.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/contribsys/faktory/pull/345#issuecomment-816772555, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAAWX66V2Q46EQMPRUCDODTH4N7DANCNFSM42TTYG3A

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/contribsys/faktory/pull/345#issuecomment-816796826, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPHCMIAYS2JPZCHNTFQWETTH4SLVANCNFSM42TTYG3A .

christopherdiehl commented 3 years ago

@mperham Any thoughts on how to resolve the compilation errors on the current release, and is there anything I can do to help on my side?

mperham commented 3 years ago

I'm working on a 1.5.1 release now.

mperham commented 3 years ago

Thanks for your patience, I was helping another customer with some other fixes too. 1.5.1 is now out.

https://github.com/contribsys/faktory/blob/master/Changes.md#151