search

contribsys / faktory

Language-agnostic persistent background job server
https://contribsys.com/faktory/
Other
5.73k stars 227 forks source link

Faktory UI Bootstrap 5 upgrade #359

Closed saurori closed 3 years ago

saurori commented 3 years ago

Placeholder issue to discuss upgrading the UI from Bootstrap 3 -> 5.

Pinging @mperham to add additional context.

mperham commented 3 years ago

Thanks for asking and I appreciate the offer! My request is that any upgrade keep the similar static assets as today. I don't want a dynamic build process which creates the bootstrap.css. I hope this is not a problem!

saurori commented 3 years ago

Not a problem. Makes it a bit more tedious albeit simpler, but shouldn't be an issue.

mperham commented 3 years ago

You are certainly welcome to add tasks to the Makefile which document and help with creating the static CSS but I want this to be something I only have to run every time I want to upgrade Bootstrap, not with every Faktory build or release.

saurori commented 3 years ago

I went ahead with the original strategy and updated the static files (will PR something tomorrow). Making a front-end build process (with SASS, webpack, etc) could be another project that would make it easy to build custom bootstrap css and js dist files using only the modules you want. The development experience would be nicer as well (live reload css/js changes, hashed asset files, etc).