search

contribsys / faktory

Language-agnostic persistent background job server
https://contribsys.com/faktory/
Other
5.76k stars 229 forks source link

add OK response for END command #376

Closed ghilesmeddour closed 3 years ago

ghilesmeddour commented 3 years ago

Minor fix to meet FWD specification for END command responses

https://github.com/contribsys/faktory/blob/master/docs/protocol-specification.md#end-command

If the client requests the end state, the server MUST send an OK response to the END command before the server closes the connection; and the client MUST read the OK response to the END command before the client closes the connection.
mperham commented 3 years ago

I don't accept PRs without description.

ghilesmeddour commented 3 years ago

I just added it.

mperham commented 3 years ago

Thanks for pointing out the discrepancy.

I think for backwards compatibility we should update the protocol specification to the current behavior. Otherwise a "proper" new client working against an older Faktory version will hang upon sending END, waiting for the OK.