search

contribsys / faktory

Language-agnostic persistent background job server
https://contribsys.com/faktory/
Other
5.71k stars 228 forks source link

Label CSS missing in new Bootstrap #383

Closed mperham closed 2 years ago

mperham commented 2 years ago

Looks like the Bootstrap 5 upgrade by @saurori might have excluded the label classes. I see something called badges in v5 but I don't see the semantic classes like label-info, label-danger, etc which we used for coloring purposes.

https://getbootstrap.com/docs/3.4/components/#labels

In this image, the "golang-1.5.0" text should be in a colored box.

Screen Shot 2021-10-06 at 11 37 19 AM

Help?

saurori commented 2 years ago

Yeah they need to be replaced with badges with a background color.

So for example label-info -> badge bg-info. Or label-danger -> badge bg-danger

See: https://getbootstrap.com/docs/5.1/components/badge/#background-colors

I can make a PR later or tomorrow. Otherwise it should be an easy fix for you or someone else to handle.

mperham commented 2 years ago

Thanks, looks like it only affected that one spot so I've fixed it.