contribsys / faktory

Language-agnostic persistent background job server
https://contribsys.com/faktory/
Other
5.78k stars 230 forks source link

Unwrap ActiveJob job class in WebUI #460

Closed ibrahima closed 11 months ago

ibrahima commented 11 months ago

Unwraps ActiveJob job classes in the web UI.

This does not unwrap the arguments, but that would be a nice addition as well.

Based on similar logic from Sidekiq, thanks for the pointer @mperham! I barely understand Go so I hope the code is okay.

https://github.com/sidekiq/sidekiq/blob/73c150d0430a8394cadb5cd49218895b113613a0/lib/sidekiq/api.rb#L374-L389

Before:

image

After:

(This is from the "queue" page, which uses Type for the column, and apparently a darker font.)

image

image

Fixes #459

mperham commented 11 months ago

Wow, this is great stuff. Well done, I'm impressed.

ibrahima commented 11 months ago

Thanks!