search

contribsys / faktory

Language-agnostic persistent background job server
https://contribsys.com/faktory/
Other
5.78k stars 230 forks source link

makefile support for arm64 packaging #481

Closed Zambiorix closed 4 months ago

Zambiorix commented 4 months ago

existing targets work as usual

New targets:

package_rpm
package_deb

package_amd64
package_rpm_amd64
package_deb_amd64

package_arm64
package_rpm_arm64
package_deb_arm64

package_base_name
mperham commented 4 months ago

I don’t think this will build arm64 for release if your goal is released packages.

Zambiorix commented 4 months ago

make package does not build release packages?

mperham commented 4 months ago

It does but where is each arch explicitly built? I don't see where you actually build both arches.

Zambiorix commented 4 months ago

make package now builds packages for both amd64 and arm64 I have split the clean target, to perform some cleaning between architecture builds and making sure the output folder is not deleted.

Zambiorix commented 4 months ago

Ok, xbuild now builds both archs as faktory_amd64 and faktory_arm64 deb and rpm force copy the output to faktory to keep the package names intact. They both first start with arm64 and then amd64, leaving the last one undeleted, mimicking the same behavior of this makefile before the change.

clean is updated

.gitignore is updated

mperham commented 4 months ago

Thank you, nice work!