search

contribsys / faktory_worker_go

Faktory workers for Go
Mozilla Public License 2.0
242 stars 43 forks source link

Queues from worker.NewManager() is no longer exported, causing a breaking change #21

Closed CaryLandholt closed 5 years ago

CaryLandholt commented 5 years ago

Queues was being exported, but was renamed to queues causing apps to break. https://github.com/contribsys/faktory_worker_go/blob/master/runner.go#L42

Is the intent to use ProcessStrictPriorityQueues and/or ProcessWeightedPriorityQueues in lieu of Queues?

mperham commented 5 years ago

Yes, readme was adjusted to show the new api.

On Jan 25, 2019, at 09:49, Cary Landholt notifications@github.com wrote:

Queues was being exported, but was renamed to queues causing apps to break. https://github.com/contribsys/faktory_worker_go/blob/master/runner.go#L42

Is the intent to use ProcessStrictPriorityQueues and/or ProcessWeightedPriorityQueues in lieu of Queues?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

CaryLandholt commented 5 years ago

Thanks for the clarification. Will there be a versioning scheme put in place in the future, such as http://labix.org/gopkg.in?

mperham commented 5 years ago

Until 1.0 the API can fluctuate. I have a Version variable but I need to implement version tagging in the repo.