search

contribsys / faktory_worker_go

Faktory workers for Go
Mozilla Public License 2.0
242 stars 43 forks source link

Shutdown/Quiet events aren't fired #9

Closed hassansin closed 6 years ago

hassansin commented 6 years ago

Worker doesn't response to shutdown/quiet actions from the server. https://github.com/contribsys/faktory_worker_go/blob/master/runner.go#L140 . Here server is returning json response of {"state":"quiet"}, but the client is checking against plain text. Might need a json parsing. I can send a PR with the fix.

mperham commented 6 years ago

A PR would be very welcome!

On Apr 21, 2018, at 09:25, Hassansin notifications@github.com wrote:

Worker doesn't response to shutdown/quiet actions from the server. https://github.com/contribsys/faktory_worker_go/blob/master/runner.go#L140 . Here server is returning json response of {"state":"quiet"}, but the client is checking against plain text. Might need a json parsing. I can send a PR with the fix.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.