search

contribsys / faktory_worker_ruby

Faktory worker for Ruby
GNU Lesser General Public License v3.0
214 stars 31 forks source link

Version bump to 0.7.1 - For ActiveJob adapter #20

Closed jagthedrummer closed 6 years ago

jagthedrummer commented 6 years ago

Would love to start using the AJ adapter in the wild.

mperham commented 6 years ago

I've added you as a collaborator. You are welcome to bump the version yourself. Don't forget to maintain the changelog with recent changes.

Also, if you have a rubygems account, I'd be happy to add you as a backup gem owner too just in case of emergency.

jagthedrummer commented 6 years ago

I just pushed an update to Changes.md to mention the adapter. I figure I'll make a wiki page about it, and another one about the testing stuff.

On a related note, I see the "Contributor" designation on my comments here, but it doesn't look like I have write access to the repo. (Maybe that's as intended and I misunderstood what you mean by "You are welcome to bump the version yourself".)

On rubygems I'm jagthedrumer AT gmail.com.

mperham commented 6 years ago

Read the collaboration email invite.

mperham commented 6 years ago

Did you spell your email right? One m?

jagthedrummer commented 6 years ago

Oops, I did not spell it right, there are, in fact, 2 ms.

And I just found the invitation email that had been auto-sorted out of any of the folders I regularly check. Sorry for the confusion. Gonna merge this now.

Thanks!

mperham commented 6 years ago

Done and done! Feel free to push 0.7.1 to rubygems with rake release.

jagthedrummer commented 6 years ago

Just pushed 0.7.1 and everything worked like a charm. Woot!