search

contribsys / faktory_worker_ruby

Faktory worker for Ruby
GNU Lesser General Public License v3.0
214 stars 31 forks source link

Fix bid bleed #55

Closed ffiller closed 3 years ago

ffiller commented 3 years ago

@mperham As discussed. Please let me know if you are happy with this test or if any additional context is needed to document for posterity.

mperham commented 3 years ago

I'm going to add a little more defensiveness to the code but this is a great start. Thanks again!

ffiller commented 3 years ago

Yeah, was thinking of tackling it in the Job module, but didn't want to send a huge PR. Can you release 1.0.3 once you're done? Thanks!

mperham commented 3 years ago

^^^^ There's my second pass at a fix. We need to ensure the problem is solved for any middleware so I dup before invoking the client middleware chain.

mperham commented 3 years ago

1.0.3 has been released. LMK how it works for you.

ffiller commented 3 years ago

@mperham Yes, that's a better fix. Works beautifully! Thanks again, and enjoy your week :)