search

contribsys / faktory_worker_ruby

Faktory worker for Ruby
GNU Lesser General Public License v3.0
214 stars 31 forks source link

Adds connect timeout #64

Closed manuelvanrijn closed 2 years ago

manuelvanrijn commented 3 years ago

Will implementing https://github.com/ankane/the-ultimate-guide-to-ruby-timeouts/pull/34, I was trying to handle connection timeouts, but noticed this wasn't implemented.

At this point I choose to raise an Faktory::TimeoutError. If you like I can modify it to raise a more specific timeout error class, for instance Faktory::ConnectionTimeoutError?

mperham commented 3 years ago

I don’t want any usage of Timeout if possible. You can look at other network clients to see how they implemented the same functionality without Timeout.