search

contributor-assistant / github-action

CLA Assistant GitHub Action
Apache License 2.0
281 stars 93 forks source link

[BUG] Unrelated user is tagged with @ in comment #91

Open ivan opened 3 years ago

ivan commented 3 years ago

Describe the bug

On a project I do not control, in https://github.com/exadel-inc/CompreFace/pull/543#issuecomment-852254987, the action seems to have inserted "@ivan" in the comment, causing GitHub to send an email to an unrelated ivan (me).

To Reproduce

I don't know, but "Ivan Kurnosau seems not to be a GitHub user" is probably related.

Expected behavior

Please don't @ unrelated GitHub users, it leads to undesired email from unrelated projects.

Screenshots

Screenshot 2021-06-02 073337

pospielov commented 3 years ago

Hi there, I'm a CompreFace repository contributor and looks like I know how to reproduce it. So real Ivan Kurnosau has such config for git on a local machine: user.email: ...@exadel.com user.name: Ivan Kurnosau But his GitHub Account has another email: ...@gmail.com So, cla-assistant didn't find such a user and just used a local user.name to tag a user But because user.name has space, it tagged @ivan We will try to fix it from our side - just add the correct email to the GitHub account. But this is definitely a bug, you shouldn't try to tag unknown users.

ibakshay commented 3 years ago

Hi @ivan, I am really sorry that this GitHub action has sent you a unrelated email. I will fix this bug soon. @pospielov Thank you for the explanation :). You are absolutely right 😄.

silviogutierrez commented 2 years ago

@pospielov : I believe this is still occurring, see here: https://github.com/silviogutierrez/reactivated/pull/222