search

contributte / apitte

:wrench: An opinionated and enjoyable API framework based on Nette Framework. Supporting content negotiation, debugging, middlewares, attributes, annotations and loving openapi/swagger.
https://contributte.org/packages/contributte/apitte/
MIT License
61 stars 37 forks source link

[PHP 8.0] Pre-attributes - update annotations to named arguments #162

Closed TomasVotruba closed 3 years ago

TomasVotruba commented 3 years ago

Just making use of @NamedArgumentConstructor annotation: https://github.com/doctrine/annotations/blob/1.11.x/docs/en/custom.rst#optional-constructors-with-named-parameters

This will make https://github.com/apitte/core/pull/161 much easier to add :+1: Merge this PR befor that one


I found it by miracle today in here :) https://github.com/koriym/Koriym.Attributes#compatible-annotation

TomasVotruba commented 3 years ago

Ready for review and merge :+1:

There is no behavior change in this PR, just syntax suggar for future attributes

f3l1x commented 3 years ago

PIng @TomasVotruba

TomasVotruba commented 3 years ago

Oh crap, the CI needs your approval again :facepalm: Could you click it?

I hope this will disappear once you merge at least one of my PRs and I'll become "verified" real user :laughing:

TomasVotruba commented 3 years ago

The least I could do is to run PHP 7.2 single failed test DI/ApiExtension.phpt locally. It's fixed now :+1:

f3l1x commented 3 years ago

Merged, thanks.