contributte / apitte

:wrench: An opinionated and enjoyable API framework based on Nette Framework. Supporting content negotiation, debugging, middlewares, attributes, annotations and loving openapi/swagger.
https://contributte.org/packages/contributte/apitte/
MIT License
61 stars 37 forks source link

Add AnnotationAttributeDualReader that can read both annotations and attributes at the same time #165

Closed TomasVotruba closed 2 years ago

TomasVotruba commented 2 years ago

I'm testing the practise in practise and it seems the DualReader can only read annotation or attributes, not both at the same time.

That's why method like this fails:


    /**
     * @RequestParameters({
     *     @RequestParameter(in="path", type="int", name="userId", description="User ID"),
     * })
     */
    #[Path(path: '/user/{userId}/collections')]
    public function run()
    {
    }
TomasVotruba commented 2 years ago

Ready to merge :+1:

TomasVotruba commented 2 years ago

There is one more bug with doctrine/annotations... :thinking: I'm just looking into it

TomasVotruba commented 2 years ago

I've updated version to use tag, now up and CI running succesfuly :tada:

Ready to merge :heavy_check_mark:

TomasVotruba commented 2 years ago

Just curious, our project avoid dev deps to speedup compose installations on CI and make dependencies more reliable. When do you plan to release this feature?

f3l1x commented 2 years ago

I will call you on the phone. ;-)