search

contributte / componette-site

:loop: Addons, plugins, components and extensions (@componette :heart: @nette)
https://componette.org
MIT License
57 stars 12 forks source link

[QA] add phpstan #83

Closed f3l1x closed 7 years ago

f3l1x commented 7 years ago

Configuration in the README (https://github.com/phpstan/phpstan).

cc @ondrejmirtes

ondrejmirtes commented 7 years ago

@f3l1x I can prepare a PR if you'd like me to.

f3l1x commented 7 years ago

@ondrejmirtes Thanks a lot, but it not nescessary. I would like to go throw the readme and handle possible breakpoints by my self. I can provide some feedback after that.

Thank you for your jof on @phpstan. It looks like a great missing tool for PHP world. :+1:

ondrejmirtes commented 7 years ago

@f3l1x OK, just show me the integration before merging so I can give my 2 cents on it :)

f3l1x commented 7 years ago

@ondrejmirtes I've finally integrated it. :-) Good job btw, phpstan's hits are pretty useful and I didn't get lost.

I would be happy if you could take a look.

ondrejmirtes commented 7 years ago

@f3l1x Cool, it's nice :) 👍 Are you still extending Nette\Object for BC reasons?

f3l1x commented 7 years ago

@ondrejmirtes Well, I do not, but nextras/orm does, so I cannot avoid it.