search

contributte / console

:boom: Best minimal console (symfony/console) to Nette Framework (@nette)
https://contributte.org/packages/contributte/console.html
MIT License
93 stars 32 forks source link

Feature: support for nette/di:v3.0.0-dev #17

Closed solcik closed 6 years ago

solcik commented 6 years ago

This one is not a BC, but has been a blocker for v3-dev.

https://github.com/nette/di/blob/master/src/DI/ServiceDefinition.php#L70

Do you plan to support nette v3-dev packages, or you are waiting for official release? Should I send more PRs (to other packages) with support for nette/di:v3-dev?

f3l1x commented 6 years ago

Well... Thanks for the PR.

I would like to wait and stand at v2.4 until official v3.0.0 will be released.

I've written down a official statement here.

Btw, it will be nice if you prepare some PR in the future. ;-)

solcik commented 6 years ago

Do you mind if I am going to fork contribute/nettrine packages, try to make them in sync with nette/di:3.0.0-dev and publish them (never done it before I wanna try) only for me. I do not want to diverge (make one more package), I will make everywhere statements to contributte and when the time comes I will create pull requests and delete packages.

f3l1x commented 6 years ago

Sure, do whatever you want to. :-) I think it's waste of time. There's no really difference between 2.4 and 3.0.

jiripudil commented 6 years ago

This change imo merely introduces compatibility with future 3.0, without breaking compatibility with 2.4, and therefore could be merged right away. The usage of setClass has been marked as deprecated in 2.4.10 anyway, it just doesn't trigger deprecation warnings yet.

solcik commented 6 years ago

That's what I wrote in the first comment, that it is not a BC break.) therefore could be merged..

f3l1x commented 6 years ago

Hi. You're right guys, it's not a BC break.

f3l1x commented 6 years ago

Thanks @solcik