search

contributte / console

:boom: Best minimal console (symfony/console) to Nette Framework (@nette)
https://contributte.org/packages/contributte/console.html
MIT License
91 stars 32 forks source link

Add console Application to DI container exported types #53

Closed redwormik closed 3 years ago

redwormik commented 3 years ago

Hello, when I turn off type exporting of Nette DI container like this:

di:
    export:
        parameters: no
        tags: no
        types:

I have to add Contributte\Console\Application to the types to get it by type in bin/console, while e.g. Nette\Application\Application works "out-of-the-box", because it is added to compiler's exported types in ApplicationExtension, i.e. it is always exported.

This PR likewise adds Contributte\Console\Application to compiler's exported types, so it works even when other types are not exported.

redwormik commented 3 years ago

@f3l1x Hello, can I do anything to help this? If you do not think it is a good idea, feel free to close it :slightly_smiling_face:

f3l1x commented 3 years ago

I like it, could you please export types before end of loadConfiguration? With comment // Export types. Thx.

f3l1x commented 3 years ago

👍