search

contributte / console

:boom: Best minimal console (symfony/console) to Nette Framework (@nette)
https://contributte.org/packages/contributte/console.html
MIT License
91 stars 32 forks source link

Update ConsoleExtension.php #76

Closed janzarubadek closed 8 months ago

janzarubadek commented 8 months ago

Lazy loading using the service tag does not work.

f3l1x commented 8 months ago

Hey ✋ @janzarubadek. Is the tag really needed? Describe me please your use-case.

janzarubadek commented 8 months ago

Hey ✋ @janzarubadek. Is the tag really needed? Describe me please your use-case.

Hi, I replaced kdyby/console with this contributte/console. Without this feature, there is no point for us to use this package and it will be removed from our products. Cases of use can be seen in the old kdyby products. Thanks.

f3l1x commented 8 months ago

I don't get it. Why do you need use tag for lazy-loading? All commands are lazy-loaded by default by it's type. What's the case you need tag?

codecov[bot] commented 8 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

janzarubadek commented 8 months ago

I don't get it. Why do you need use tag for lazy-loading? All commands are lazy-loaded by default by it's type. What's the case you need tag? Kdyby DI extensions insert commands dynamically: $builder->addDefinition(....)->addTag(.... Sorry. I don't have the space for a complete rebuild. Many important people here consider nette a dying project etc...

Besides, it is written in your documentation that it is supported.

f3l1x commented 8 months ago

I will add this tag support back, just for you.

PS: Do you have Slack or something? I would like to hear about your project more and also discuss it how do use it with Kdyby, because Kdyby does not support nette v4 or does?