search

contributte / datagrid

:muscle: DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc
https://contributte.org/packages/contributte/datagrid/
MIT License
285 stars 189 forks source link

Fix ElasticsearchDataSource.php data source #1041

Closed Creeperface01 closed 1 year ago

Creeperface01 commented 1 year ago

I don't think the data source should be the client since it's quite pointless to provide to filter condition

radimvaculik commented 1 year ago

@Creeperface01 Could you rebase and point the branch to next branch, please?

radimvaculik commented 1 year ago

Also, could you bump elasticsearch dependency as composer offer new version.

elasticsearch/elasticsearch v7.17.1 v8.6.0 PHP Client for Elasticsearch
radimvaculik commented 1 year ago

@Creeperface01 Thanks for contribution 👍