Fixing custom classes on checkbox in inline edit

contributte / datagrid

:muscle: DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc

MIT License

285 stars 189 forks source link

Open Spilky opened 1 year ago

Spilky commented 1 year ago

\Nette\Forms\Controls\Checkbox::getControl returns label part and control part like one \Nette\Utils\Html and then $control->getControl()->getAttribute('class') is always null (because it takes class from label) and custom defined classes are always overwritten by $control->setAttribute('class', 'form-control input-sm form-control-sm');
fixed by using \Nette\Forms\Controls\BaseControl::getControlPrototype which always returns only control part without label part

MrVoltz commented 1 year ago

I am having the same issue, I think that in addition to your fix, there should be a condition for TextBase and SelectBox.

radimvaculik commented 1 year ago

Good for me! 👍 @paveljanda / @f3l1x Please merge it.