search

contributte / datagrid

:muscle: DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc
https://contributte.org/packages/contributte/datagrid/
MIT License
285 stars 189 forks source link

Return value of BackedEnum when reading Doctrine entity property. #1080

Closed juniwalk closed 1 year ago

juniwalk commented 1 year ago

Should I add this elsewhere in Row class?

radimvaculik commented 1 year ago

@juniwalk Thanks for PR. Could you introduce some tests as well, please?

juniwalk commented 1 year ago

@radimvaculik I added needed test, however it is php8.1 feature, Should I mark it somehow to test only for php8.1?

juniwalk commented 1 year ago

Well I fixed the test but that codesniffer error I can't find it and the output doesn't tell you where the issue is.

Edit: Aha, I see the issue here in github, however I did put new line there, wth?

radimvaculik commented 1 year ago

Could you point it to next branch, please?

juniwalk commented 1 year ago

image

It should be pointed into next