contributte / datagrid

:muscle: DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc
https://contributte.org/packages/contributte/datagrid/
MIT License
285 stars 189 forks source link

Wrong display of toolbar & export buttons #1101

Closed elring closed 8 months ago

elring commented 8 months ago

After commit 55fd8b4 the toolbar look wrong:

image

  1. The buttons are without any space between - this is because of now wrong CSS selector in datagrid.css - extra div is now needed - line 74 should be changed to:
    
    .datagrid .datagrid-toolbar > div > span > a {
    margin-left: 0.5em;
    }

2. The export buttons are on new line - this is because of the new snippet div - the export toolbar is outside of it. This can be solved either by moving the export toolbar into the new snippet or by css "hack" of the snippet div:

.datagrid .datagrid-toolbar > div { display: inline-block; }



After these changes, toolbar looks better:

![image](https://github.com/contributte/datagrid/assets/24586123/46de41a5-ae68-494b-9911-40c6d79b2dfb)

Should I make PR (which way for 2)?
paveljanda commented 8 months ago

1) Yes, pls create a new MR, thanks! 👍 2) I am not sure I follow - what do you mean by which way for 2?

elring commented 8 months ago
  1. Here you are :)
  2. I chose not to modify template and stick with CSS changes (the question was about this - move span snippet exports in template or create new CSS rule).
paveljanda commented 8 months ago

Thx 👍