_datagrid_name should be uniqueId of component

contributte / datagrid

:muscle: DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc

https://contributte.org/packages/contributte/datagrid/

MIT License

288 stars 189 forks source link

_datagrid_name should be uniqueId of component #753

Open martinknor opened 5 years ago

martinknor commented 5 years ago

Because $.nette.ext('datagrid.reset-filter-by-column' works with name, but if component is under other component - link to reset column doesnt work.

For example, i have component test and grid under test component. link to reset filter is &do=test-grid-resetFilter, but name is only grid and nette.ext would change &do=grid-resetFilter

new_href = href.replace('do=' + payload._datagrid_name + '-resetFilter', 'do=' + payload._datagrid_name + '-resetColumnFilter');

Sofiosko commented 5 years ago

I Agree, can you make a pull request? I do not know if owner maintains this library but this is easy fix.