contributte / datagrid

:muscle: DataGrid for Nette Framework: filtering, sorting, pagination, tree view, table view, translator, etc
https://contributte.org/packages/contributte/datagrid/
MIT License
292 stars 195 forks source link

[7.x] 🎨 Bootstrap 5 support #946

Open radimvaculik opened 3 years ago

radimvaculik commented 3 years ago

https://getbootstrap.com/docs/5.0/migration/

Libs

f3l1x commented 2 years ago

Ref: https://github.com/contributte/datagrid/pull/1021

MartinKokesCz commented 1 year ago

I just want to mention, that Bootstrap 5 doesn't contain datepicker by default. I know that it would be cool to have great BS5 datepicker (for example like this https://mdbootstrap.com/docs/standard/forms/datetimepicker/), but I think that there must be a whole new project/package and currently I have not found any open source without the jQuery dependency.

So just a question - Can we use the "simple" date and datetime input type? https://caniuse.com/input-datetime ? I think, that it will not break any promise of BS 5 support, because the datepicker is not included in core BS5 package.

What do you think?

f3l1x commented 1 year ago

Simple date and datetime input type sounds great, totally in 💯

radimvaculik commented 1 year ago

@MartinKokesCz Could you introduce a PR, please? 🙏

MartinKokesCz commented 1 year ago

@MartinKokesCz Could you introduce a PR, please? 🙏 @radimvaculik ok, I will try.

MartinKokesCz commented 1 year ago

I have started in https://github.com/MartinKokesCz/datagrid/tree/datepicker-input

MartinKokesCz commented 1 year ago

@radimvaculik sending PR #1096