contributte / doctrine-dbal

:bulb: Well-integrated Doctrine DBAL for Nette Framework (@nette)
https://contributte.org/packages/nettrine/dbal.html
MIT License
30 stars 26 forks source link

Support PHP 8.2 #74

Closed foxycode closed 1 year ago

foxycode commented 1 year ago

Is support for PHP 8.2 possible? After update to PHP 8.2, version of nettrine/dbal was downgraded to v0.7.0.1.

f3l1x commented 1 year ago

Cao @foxycode. Support PHP 8.2 needs some work from my side. I need to install PHP 8.2 at first. Still on PHP 8.1.

foxycode commented 1 year ago

@f3l1x Not using Docker? 🙂

Can I help somehow?

f3l1x commented 1 year ago

Too old for this stuff. 😂

foxycode commented 1 year ago

@f3l1x I thought so too, can explain if you want :slightly_smiling_face: I don't even have PHP directly on my system these days :slightly_smiling_face:

Is underline DBAL capableof PHP 8.2? If yes, I could prepare PR.

jvitasek commented 1 year ago

Hey guys, I would use 8.2 support too. Can help with the PR.

foxycode commented 1 year ago

I tried myself and doctrine/dbal:^3.2 installed on PHP 8.2 without problem:

# composer require doctrine/dbal:^3.2
Info from https://repo.packagist.org: #StandWithUkraine
./composer.json has been created
Running composer update doctrine/dbal
Loading composer repositories with package information
Updating dependencies
Lock file operations: 6 installs, 0 updates, 0 removals
  - Locking doctrine/cache (2.2.0)
  - Locking doctrine/dbal (3.5.1)
  - Locking doctrine/deprecations (v1.0.0)
  - Locking doctrine/event-manager (2.0.0)
  - Locking psr/cache (3.0.0)
  - Locking psr/log (3.0.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 6 installs, 0 updates, 0 removals
  - Downloading psr/log (3.0.0)
  - Downloading psr/cache (3.0.0)
  - Downloading doctrine/event-manager (2.0.0)
  - Downloading doctrine/deprecations (v1.0.0)
  - Downloading doctrine/cache (2.2.0)
  - Downloading doctrine/dbal (3.5.1)
  - Installing psr/log (3.0.0): Extracting archive
  - Installing psr/cache (3.0.0): Extracting archive
  - Installing doctrine/event-manager (2.0.0): Extracting archive
  - Installing doctrine/deprecations (v1.0.0): Extracting archive
  - Installing doctrine/cache (2.2.0): Extracting archive
  - Installing doctrine/dbal (3.5.1): Extracting archive
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
3 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found

Oldest 3.2.0 works with 8.2 too:

# composer require doctrine/dbal:3.2.0
./composer.json has been updated
Running composer update doctrine/dbal
Loading composer repositories with package information
Updating dependencies
Lock file operations: 7 installs, 0 updates, 0 removals
  - Locking composer/package-versions-deprecated (1.11.99.5)
  - Locking doctrine/cache (2.2.0)
  - Locking doctrine/dbal (3.2.0)
  - Locking doctrine/deprecations (v0.5.3)
  - Locking doctrine/event-manager (1.2.0)
  - Locking psr/cache (3.0.0)
  - Locking psr/log (3.0.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 7 installs, 0 updates, 0 removals
  - Downloading composer/package-versions-deprecated (1.11.99.5)
  - Downloading doctrine/deprecations (v0.5.3)
  - Downloading doctrine/event-manager (1.2.0)
  - Downloading doctrine/dbal (3.2.0)
  - Installing composer/package-versions-deprecated (1.11.99.5): Extracting archive
  - Installing psr/log (3.0.0): Extracting archive
  - Installing psr/cache (3.0.0): Extracting archive
  - Installing doctrine/deprecations (v0.5.3): Extracting archive
  - Installing doctrine/event-manager (1.2.0): Extracting archive
  - Installing doctrine/cache (2.2.0): Extracting archive
  - Installing doctrine/dbal (3.2.0): Extracting archive
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
4 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
foxycode commented 1 year ago

@f3l1x Can you please allow write to this repo too, so I can make PR directly?

haltuf commented 1 year ago

+1 to this. Let me know, if we can help somehow.

f3l1x commented 1 year ago

Thank you folks, can you join our mini group? https://pehapkari.slack.com/archives/CBD9G0GET/p1673630370192599

f3l1x commented 1 year ago

nettrine/dbal is allowed to install on PHP 8.2, but it requires doctrine 3.5+.

https://github.com/contributte/doctrine-dbal/commit/0438dc7b692567ac77b7e94be27f8b135970dd82 https://github.com/contributte/doctrine-dbal/commit/e5d38af256c05617c1387ecba8f04ec58c32447a

holantomas commented 1 year ago

Hi, @f3l1x I see commits that you did was created at Jan 13. And latest realease is at Jan 13. Is it mistake that latest v0.8.1 still don't support PHP 8.2? >=7.4 <8.2?