Feature/diagnostics - Githubissues

contributte / event-dispatcher

:boom: Best events support (symfony/event-dispatcher) to Nette Framework (@nette)

https://contributte.org/packages/contributte/event-dispatcher.html

MIT License

28 stars 8 forks source link

Feature/diagnostics #22

Closed rattuscz closed 7 months ago

rattuscz commented 3 years ago

Still a bit of work in progress:

what should be in the debug panel? right now it's just a list of dispatched events plus list of registered listeners
Also would love better icon if someone could find/create :-)

as mentioned it adds two new dependencies - Tracy and psr/log. I've kept them in require-dev but psr/log should probably go to normal require as it does not need to be only for development.

rattuscz commented 3 years ago

ok I've rewritten it to use loggers only, but have one problem with php7.2 compatibility:

Diagnostics/DiagnosticDispatcher.php : 77 Method Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() invoked with 2 parameters, 1 required.

as the signature changed between symfony versions, how to make it work with phpstan? any ideas? :-)

f3l1x commented 3 years ago

I am ok with support only last versoin :-)

petrparolek commented 1 year ago

Great work! I rebased this PR and dev-master and it works as I expected. Is it still in WIP?

rattuscz commented 1 year ago

Well i'm using this version on my project for over 2 years and had no troubles :-) I was not able to finish fixing the stan/tests to get green results here.

f3l1x commented 7 months ago

Manually merged. Thank you for your work @rattuscz, well done. 👍

https://github.com/contributte/event-dispatcher/releases/tag/v0.9.0