search

contributte / forms-bootstrap

👾 Bootstrap 4 + 5 forms for Nette framework
MIT License
19 stars 19 forks source link

Support for nette/forms 3.1.14 #86

Closed matoni555 closed 8 months ago

matoni555 commented 9 months ago

Can you please add support for current release of nette/forms (3.1.15)?

Thank you

f3l1x commented 9 months ago

@dakorpar Please, unlock for all 3.1.x, it does not make any sense to update every two weeks.

dakorpar commented 9 months ago

@f3l1x that will lead to MANY sites crashed after composer update. Nette/forms has BC every now and then and this library is also using internal functions that can change at any time. I did that mistake in beggining, won't do it again. Plus v3.1.14 adds new controls which I actually need to support here. image

I'll update in next few days.

f3l1x commented 9 months ago

OK.

dakorpar commented 9 months ago

Hmm, this is a bit tricky now... We already have Date and Datetime control in. Now if I switch to nette one it's breaking change and if I introduce a new different function for nette native controls interface won't be almost the same with nette forms anymore... I'll have to investigate more... @matoni555 feel free to send PR, this will probably be on hold for few more days if it's waiting for me. just changing composer.json IS NOT an option.

H0w4rd commented 8 months ago

Hi, any idea how to solve this problem?

darkWolf-PR commented 8 months ago

@dakorpar I´d say using the Nette ones is the right way, Dfferent way can just add more problems. Declare new version with breaking change. If Nette/Forms can do BCs and it does not matter that sites crash after composer update, there is no point going around with component that expands on NetteForms. And no one should be running composer update on production...

dakorpar commented 8 months ago

I'm a bit buisy, if someone prepares a PR I'll take a look and modify if needed in day or two then, but to buisy to actually focus on that ATM.

H0w4rd commented 8 months ago

So you are going to rename those methods that are in conflict with the ones in nette/forms?

dakorpar commented 8 months ago

@H0w4rd I don't have much room there... I have to stay compatible with nette forms, which means compatibility with nette/forms 3.1.14 will include BCs... I've added new date/datetime/time/color controls now and had to rename current addDate and addDateTime to addBootstrapDate and addBootstrapDateTime... That's only thing I can do since my container basically "inherits" nette container and all calls need to be compatible... I'll do some testing tomorrow... you can all also try it out with including: "contributte/forms-bootstrap": "v0.7",

dakorpar commented 8 months ago

compatibility with 3.1.15 done and released. 3.2.0 is also ready and will be released probably tomorrow. closing this