contributte / forms-multiplier

:repeat: Form multiplier & replicator for Nette Framework
https://contributte.org/packages/contributte/forms-multiplier.html
MIT License
26 stars 20 forks source link

Mostly revert "Fixes for nested multipliers (#59)" #110

Closed jtojnar closed 2 months ago

jtojnar commented 2 months ago

This partially reverts commit 39725d333355b2a1ef21dac3948909cf1e5d4744.

The commit introduced a regression in testGroupManualRenderWithButtons, changed the internal architecture in a way that made it harder to reason about (the Multiplier inconsistently took over some responsibilities of ComponentResolver). Additionally, it applied the following changes that are unrelated to the purported fix and not really necessary:

We are only keeping the following:

For reference, the reverted change is the following commit that was squashed into 39725d333355b2a1ef21dac3948909cf1e5d4744, except for the change to testSendNested: https://github.com/contributte/forms-multiplier/pull/59/commits/2c33de22b8343ba08210764711e4776a5bf58227