contributte / forms-multiplier

:repeat: Form multiplier & replicator for Nette Framework
https://contributte.org/packages/contributte/forms-multiplier.html
MIT License
26 stars 21 forks source link

Fixed Argument 2 passed to Contributte\FormMultiplier\ComponentResolver::__construct() must be of the type array, object given #52

Closed martenb closed 3 years ago

martenb commented 4 years ago

Fixed Argument 2 passed to Contributte\FormMultiplier\ComponentResolver::__construct() must be of the type array, object given

diegosardina commented 4 years ago

A bit more words? Maybe you are using ->setMappedType() in your form?

martenb commented 4 years ago

No, i'm not. This error occurs, when i click on add (createButton). I have nested multiplier. This is, how $this->createContainer()->getValues() looks like

image

diegosardina commented 4 years ago

I have nested multiplier.

I got it.

At the beginning I wasn't able to reproduce the problem because nesting of multipliers didn't work. I had to use this work-around for the add button: https://forum.nette.org/cs/31918-zanoreny-multiplier-v-dalsim-multiplieru

Unfortunately this component looks unmaintained :-(

martenb commented 4 years ago

Ok, maybe i was not clear. Everything Is working fine with this fix..

martenb commented 4 years ago

Do you need some more informations?

martenb commented 4 years ago

Any news about merging the fix?

diegosardina commented 4 years ago

I guess this component is not currently maintained (I have also two PRs pending).

This is very unfortunate because this component is really useful

petrparolek commented 4 years ago

ping @MartkCz

martenb commented 4 years ago

ping @f3l1x

f3l1x commented 4 years ago

Hi guys. Could you please, at least, add some tests? I am not using this pkg, so it's blackbox for me. If you want to merge from me, I need some assurance. Yep?

martenb commented 4 years ago

@f3l1x

Found it, how to test it! Do you need to swap commits? First test, then fix?

martenb commented 4 years ago

Similar problem #53

martenb commented 3 years ago

ping @f3l1x

f3l1x commented 3 years ago

Merged. Thanks.