search

contributte / forms-multiplier

:repeat: Form multiplier & replicator for Nette Framework
https://contributte.org/packages/contributte/forms-multiplier.html
MIT License
26 stars 21 forks source link

Fix phpstan issues #64

Closed jankonas closed 3 years ago

jankonas commented 3 years ago

Not sure whether Multiplier::$form should be marked as nullable or not. If not, change to this PR is needed (just say the word, it's not a difficult fix).

Closes #62

f3l1x commented 3 years ago

I think form is nullable at some state, looks good to me.

MartkCz commented 3 years ago

@jankonas Thanks for PR, better way than $this->form is $this->getForm(), I would remove property $form is useless

jankonas commented 3 years ago

@jankonas Thanks for PR, better way than $this->form is $this->getForm(), I would remove property $form is useless

Might be, but I think it is out of the scope of this PR. I did not introduce new calls of $this->form, just added checks that it's not null before existing calls.

f3l1x commented 3 years ago

What do you think @MartkCz ?

MartkCz commented 3 years ago

We can merge