search

contributte / forms-multiplier

:repeat: Form multiplier & replicator for Nette Framework
https://contributte.org/packages/contributte/forms-multiplier.html
MIT License
26 stars 21 forks source link

PHP 8.3.3 #90

Closed ViPErCZ closed 6 months ago

ViPErCZ commented 7 months ago

Declaration of Contributte\FormMultiplier\Multiplier::setValues($values, bool $erase = false): Contributte\FormMultiplier\Multiplier must be compatible with [Nette\Forms\Container::setValues]

Nette Form 3.2.0

jtojnar commented 7 months ago

This has been fixed by https://github.com/contributte/forms-multiplier/commit/9b4e600be60dfbef5861ecd012b0b57d94837d1a

radimvaculik commented 7 months ago

@f3l1x Could you make a release, please? 🙏

jtojnar commented 7 months ago

The current master is still a bit broken. I am working on a fix but in the meanwhile it might be a good idea to backport https://github.com/contributte/forms-multiplier/commit/9b4e600be60dfbef5861ecd012b0b57d94837d1a and release 4.0.1.

radimvaculik commented 6 months ago

@jtojnar Did you manage to fix the bug? Otherwise, we should backport https://github.com/contributte/forms-multiplier/commit/9b4e600be60dfbef5861ecd012b0b57d94837d1a and release 4.0.1. Cheers.

jtojnar commented 6 months ago

Not yet. Please give https://github.com/contributte/forms-multiplier/pull/102 a try, will cut a release from it later if nobody complains.

jtojnar commented 6 months ago

Released 4.0.1.

By the way, turns out this issue is unrelated to PHP version. It was actually caused by nette/forms 3.2.0 changing the type signature of Container::setValues. Well, I guess this is our bad for overriding @internal method.