search

contributte / forms-multiplier

:repeat: Form multiplier & replicator for Nette Framework
https://contributte.org/packages/contributte/forms-multiplier.html
MIT License
26 stars 20 forks source link

Fix tests with nette/component-model 3.1.0 #91

Closed jtojnar closed 5 months ago

jtojnar commented 5 months ago

Container::getComponents() returns array when $deep is false: https://github.com/nette/component-model/commit/7f613eed7f5e57b6bde2d0be1bfdbb7e161620b3

jtojnar commented 5 months ago

There is still breakage from https://github.com/nette/application/commit/bb8f93c60f9e747530431eef75df8b0aa8ab9d5b in webchemistry/testing-helpers. It can be fixed with the following patch but there are other issues with it and the repo looks dead so not sure if it makes sense trying to track them down:

--- a/src/Components/Presenter.php
+++ b/src/Components/Presenter.php
@@ -31,7 +31,7 @@ class Presenter {

            $request = new Request(new UrlScript('http://localhost/'));
            $presenter->injectPrimary(
-               null, null, new RouterStub(), $request, new Response(), null,
+               $request, new Response(), null, new RouterStub(), null,
                null, $this->createTemplateFactory($request)
            );
        }

Maybe we could apply it with composer-patches plug-in.

Edit: Opened https://github.com/contributte/forms-multiplier/pull/96