latte3 compatibility - Githubissues

contributte / forms-wizard

:tophat: Easy to use step-by-step form for Nette Framework

MIT License

15 stars 10 forks source link

Closed jkavalik closed 8 months ago

jkavalik commented 1 year ago

I updated the wizard to Latte v3

implemented Latte extension
DI extension registers macros/tags depending on Latte version
tests were updated and will fail with Latte v2
changed the compatibility matrix for CI - minimal set to 7.4 (older versions are significantly EOL) and allowed tests up to 8.2

The tests pass and it works for me, but I did not do any extensive testing yet.

jkavalik commented 1 year ago

Should I only allow php8+ tests or make the tests switch paths depending on versions?

f3l1x commented 1 year ago

Hi @jkavalik. Yep, allow only PHP 8.0+. Also in composer.json.

Kocicak commented 1 year ago

Hi @f3l1x, can this PR be approved, or are you waiting for some more work to be done? Thanks

f3l1x commented 8 months ago

Hi @Kocicak @jkavalik merged. Thank you for your work here.