search

contributte / gopay

:moneybag: Integrace Gopay pro Nette Framework
MIT License
69 stars 25 forks source link

Add recurrent payments #42

Closed pabyska closed 8 years ago

vojtech-dobes commented 9 years ago

Thanks for contribution!

I have some notes - primarily it quite pollutes Service. It's bit god-like already, which isn't good, and this makes it worse. It would nicer to implement this with better architecture. What about maybe changing Payment to interface (introducing IPayment to avoid BC break). There could be then RecurringPayment which would implement setting and using all those extra parameters.

f3l1x commented 9 years ago

Thanks.

According to Vojta. I would like to split Service, to more specific services.

PayService, RecurrentService and also specific entities. Payment and RecurrentPayment.

How about that?

f3l1x commented 8 years ago

Implemented in 3.0.0.

https://github.com/Markette/Gopay/blob/master/src/Gopay/Service/RecurrentPaymentService.php

Thank you for idea.