Update phpstan to 0.12 - Githubissues

contributte / invoice

:memo: PDF invoice generator

MIT License

96 stars 25 forks source link

Closed adaamz closed 4 years ago

f3l1x commented 4 years ago

Could you please @adaamz repair CI?

adaamz commented 4 years ago

I fixed the phpstan issues, but there is some inconsistence between PHP 7.2 and PHP 7.3 BcMath. Can anybody look on that? Thanks.

MartkCz commented 4 years ago

Failing test fixed

@adaamz Could you fix cs, please?

adaamz commented 4 years ago

@MartkCz

rebased
fixed issues
updated to phpstan 0.12
installed phpstan/extension-installer (to really use required extensions in phpstan)
removed phpstan-strict-rules (almost all rules where voleted)

f3l1x commented 4 years ago

LGTM

f3l1x commented 4 years ago

Merged. Thx.