search

contributte / invoice

:memo: PDF invoice generator
https://contributte.org/packages/contributte/invoice.html
MIT License
96 stars 25 forks source link

v1.1.x - Nette extension broken in composer #3

Closed marekrost closed 7 years ago

marekrost commented 7 years ago

Versions 1.1.1 and 1.1.2 in composer change a translation prefix in InvoiceExtension.php from $builder->addDefinition($this->prefix('translator')) to $builder->addDefinition($this->prefix('translation')).

This seems to break Nette with the following exception:

Service 'invoice.invoice': Reference to missing service 'invoice.translator'. in /srv/www/test/vendor/nette/di/src/DI/ContainerBuilder.php:582 caused by Nette\DI\ServiceCreationException: Reference to missing service 'invoice.translator'. in /srv/www/test/vendor/nette/di/src/DI/ContainerBuilder.php:874.

It can be fixed either by changing the prefix name back or changing the other uses from $this->prefix('@translator') to $this->prefix('@translation').

MartkCz commented 7 years ago

Thanks, can you try v1.1.3? I forgot release new version.

marekrost commented 7 years ago

1.1.3 works OK - no complaints from nette. Thank you :+1: