Closed jaroslavlibal closed 4 years ago
Is there anything I can do to get this into some release? As I'm not an adept at javascript, I haven't done any larger refactoring. Just replaced the included netteForms.js with a new version and provided the same modifications like the original author did in the master branch + replaced listener calls.
However, I expect it to be a BC break for Nette 2.4 so this decision should be in line with the library concept of course.
Great, I'm glad that the upgrade is finally in the master, but at the same time I'm a little disappointed that I wasted my time.
I asked what else is needed to be done (here and also on slack), I declared that it works for us in production, I did three upgrades to the latest nette.forms.js version hoping it will be merged soon... and I don't know what I did wrong that my version had to remain unmegerd over a year and forever.
Hey @jaroslavlibal, I am very thankful what have you done here. From my point of view it wasn't waste of time, merged version is based on your work, so you should be proud. @dakorpar is one of stable contributte's member. There is a direct line beetween me and him, so I picked his version and deal with details.
Please, don't be sad, you have done a excellent job here. I am looking forward to your another contributtion.
The current master does not fully support Nette 3.