search

contributte / logging

:boom: Universal logging support to Tracy / Nette Framework (@nette)
https://contributte.org/packages/contributte/logging.html
MIT License
20 stars 18 forks source link

phpstan: Do not use global ignoring as it can hide bugs #21

Closed jkuchar closed 5 years ago

jkuchar commented 5 years ago

I do not agree with this global ignoring, these errors should be fixed in code:

 ------ --------------------------------------------------------------------- 
  Line   Mailer/FileMailer.php                                                
 ------ --------------------------------------------------------------------- 
  39     Binary operation "." between 'PHP: An error…' and array|string|null  
         results in an error.                                                 
 ------ --------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   Mailer/TracyMailer.php                                                 
 ------ ----------------------------------------------------------------------- 
  43     Binary operation "." between 'noreply@' and array|string|null results  
         in an error.                                                           
  48     Binary operation "." between 'PHP: An error…' and array|string|null    
         results in an error.                                                   
 ------ ----------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   SendMailLogger.php                                                   
 ------ --------------------------------------------------------------------- 
  46     Binary operation "+" between int|false and int|string results in an  
         error.                                                               
 ------ ---------------------------------------------------------------------

Should I propose PR?

f3l1x commented 5 years ago

It would be stunning!

trejjam commented 5 years ago

I think this is solved already.

jkuchar commented 5 years ago

yep, fixed