search

contributte / logging

:boom: Universal logging support to Tracy / Nette Framework (@nette)
https://contributte.org/packages/contributte/logging.html
MIT License
20 stars 18 forks source link

\Throwable #8

Closed kralmichal closed 6 years ago

kralmichal commented 7 years ago

Hi.

\Throwable interface is not available in PHP 5.6, it was introduced in PHP7. Exceptions are tested against https://github.com/contributte/logging/blob/master/src/Sentry/SentryLogger.php#L32 . No exceptions will make it through this condition.

f3l1x commented 7 years ago

You're right. Shame on me. 👍

kralmichal commented 7 years ago

I am happy to send PR. I just wanna know if removing all conditions regarding \Throwable is the correct solution.

f3l1x commented 7 years ago

It would be great, could you do that? :-)

kralmichal commented 7 years ago

Yeah. I'm going to send it tomorrow.

f3l1x commented 6 years ago

How is it going? Any updates?

kralmichal commented 6 years ago

Sorry, wasn't feeling well last week. It's on top of my todo list.

f3l1x commented 6 years ago

Resolved via #9