search

contributte / menu-control

🍔 Menu and breadcrumb components for Nette framework (@nette)
MIT License
29 stars 20 forks source link

"include" item setting #29

Closed tg666 closed 6 years ago

tg666 commented 6 years ago

Hi, I like new version (^2.0.0) of this package, implementation is much better now. Good job :+1: But I miss setting include on items e.g.

menu:
    MyMenu:
        items:
            LinkOne:
                action: :Module:Presenter:default
                include: '^Module\:Presenter\:[a-zA-Z\:]+$'

Is there any reason why this is not in version 2? Thanks for your time :slightly_smiling_face:

davidkudera commented 6 years ago

Hello and thanks I'm really glad to hear that :slightly_smiling_face:

There is no specific reason, except for the "time reason". I had to publish the 2.0 version as quickly as possible. Unfortunately I don't currently use Nette on frontend so I have also no need for this package right now.

It would be better if you could send a pull request because of that. Would you like to do that?

tg666 commented 6 years ago

Of course, I'll do it :slightly_smiling_face:

foxycode commented 6 years ago

@davidkudera I think this is already fixed.

davidkudera commented 6 years ago

@foxycode oh, you're right. Thanks