search

contributte / menu-control

🍔 Menu and breadcrumb components for Nette framework (@nette)
MIT License
28 stars 20 forks source link

Fixed Nette 3.0 compatibility #38

Closed vojta001 closed 5 years ago

vojta001 commented 5 years ago

I was just too impatient to wait for @Daaarkling to comply with his PR #35 with your requirements so I implemented the changes you @davidkudera requested. All credits go to him but since this is under MIT...

Daaarkling commented 5 years ago

@davidkudera sorry I have kind a different priorities now, but I'm glad someone finally did it :-)

davidkudera commented 5 years ago

@Daaarkling If you're apologizing for having different priorities, I would have too since I'm not event using nette anymore :wink:

@vojta001 thank you for your work :beers:

vojta001 commented 5 years ago

Could you please create a tag (release) to allow us to benefit from this fix (possibly after merging #39)?

davidkudera commented 5 years ago

@vojta001 done

foxycode commented 5 years ago

@davidkudera Maybe problem with packagist, but Composer can't find version 2.2.0 and dev-master have nette/di ^2.4 requirement.

vojta001 commented 5 years ago

@foxycode Hmmmm, interesting. I can now reproduce what you describe. I initially didn't notice since I am for some reason using this in my composer.json

"repositories": [
{
    "type": "git",
    "url": "https://github.com/Carrooi/Nette-Menu"
 }
]
davidkudera commented 5 years ago

It should work now. I moved to GitLab and so I didn't know about the removal of GitHub services.

vojta001 commented 5 years ago

It works now even without the repositories part :+1: