search

contributte / nextras-orm-generator

:wolf: Rich Nextras\ORM entity generator for fast prototyping your new project.
https://contributte.org/packages/contributte/nextras-orm-generator.html
MIT License
20 stars 14 forks source link

Fix undefined index in colomn properties #20

Closed milosjanda closed 4 years ago

milosjanda commented 4 years ago

When I look back, I see that I've changed it once, but I don't know what version I started it with then.

https://github.com/contributte/nextras-orm-generator/commit/b0002a1da7578586a83576d341e224567eaf79be

This should be correct, because nette\database is using lower case https://github.com/nette/database/commit/932822b4bc0e16233baa067c7f79e04c46c4c4e1#diff-3516ae1044fb7386783ce6cddcef72f4

Testet with nette\database version 3.0 and 2.4

dakorpar commented 4 years ago

Not sure anymore since I'm not using nextras/orm anymore but I'm sure this worked fine, best would probably be to allways do lowercase everywhere. If I just merge this chances are huge it won't work for someone else.

hrach commented 4 years ago

The best would be if this package was using Nextras Dbal reflection.

@dakorpar I'm not using nextras/orm anymore

😢

dakorpar commented 4 years ago

@milosjanda if U can add that both lowercase and uppercase are working, could be related to mariadb/mysql version as well then we can merge this.

milosjanda commented 4 years ago

It doesn't make sense to me make both style, because nette database use only lowercase. The best solution is rewrite to Nextras Dbal reflection, how @hrach mentioned. But that's is out of my focus for now.