search

control-net / Miunie

Miunie is a community developed bot with an attitude.
Other
46 stars 31 forks source link

Implement ProfileCommand & EntityConvertor #20

Closed petrspelos closed 5 years ago

petrspelos commented 5 years ago

I'm not sure how the Dependency Injection works in DSharpPlus but if it's anything like D.NET, it will require a service Container.

That service container should also include the EntityConvertor singleton. Other services from Miunie.Core should be registered manually using whatever way the CommandHandler of DSharpPlus already has.

The Actual Profile command should only delegate to ProfileService.

ProfileService will expect a MiunieUser and MiunieChannel as a parameter, meaning the EntityConvertor needs to be used to convert from Discord's IGuildUser (or similar) to MiunieUser.

:information_source: The EntityConvertor will still be used to create a MiunieChannel from the DSharpPlus channel obejct, even though it's just creating a new instance of MiunieChannel and filling in the IDs.

If the profile service does not exist at the time of completion of this, leave it blank and create a new issue for it to be finished after the ProfileService.

image

Charly6596 commented 5 years ago

I'm working on this one

petrspelos commented 5 years ago

As, @Charly6596 pointed out in his pull request #22, more work is to be done on this one.

So leaving this open.

petrspelos commented 5 years ago

This will be resolved with the #24 pull request.