search

control-net / Miunie

Miunie is a community developed bot with an attitude.
Other
46 stars 31 forks source link

😎 - User Profile Title #257

Closed TheSecurity closed 4 years ago

TheSecurity commented 4 years ago

Bug Description Miunie doesn't make difference in a title when you request for someone's profile or your profile.

image

petrspelos commented 4 years ago

Thank you, @TheSecurity! 🥇 You think you could perhaps investigate that? See if you could perhaps fix it? 😊

bitmoji

TheSecurity commented 4 years ago

Is there any deadline?

petrspelos commented 4 years ago

Nope, we didn't know about this and it's not a feature breaking bug. 😊

You've got all the time you need. Although the sooner, the better. ❤️

If you need any help, feel free to reach out to any of us. 😉

TheSecurity commented 4 years ago

@petrspelos Ok! I'll try to do my best. :)

petrspelos commented 4 years ago

The simplest solution, I think, could just be displaying something like:

Peter's Dank Profile

Of course, in English there should be no s if the name ends with it so for example:

Spelos' Dank Profile

But that should be fairly simple to do.

Of course if you have a different fix, by all means, go for it. 😊

MNiekel commented 4 years ago

That's unfortunate. Yesterday this issue was still open (and I wasn't sure @TheSecurity was still working on it). Now there was a pull request. Only noticed it when I was ready to commit changes. Well, it was a learning experience digging through the code anyway, so it's okay (and I should have asked!).