CTBase 0.13 - Githubissues

control-toolbox / CTDirect.jl

Direct transcription of an optimal control problem and resolution

http://control-toolbox.org/CTDirect.jl/

MIT License

9 stars 6 forks source link

CTBase 0.13 #216

Closed PierreMartinon closed 2 months ago

PierreMartinon commented 2 months ago

Solution constructors updated. Manual check on multipliers / constraints looks fine.

Todo: update the JSON export/read (probably fuse into save/load with a format argument)

Edit:

the missing JSON part is probably why the docs build fails
OC tests fail too, I'll check this

github-actions[bot] commented 2 months ago

Package name	latest	stable
OptimalControl.jl

PierreMartinon commented 2 months ago

Package name latest stable OptimalControl.jl

@ocots the badge correctly indicates a failure while the breakage actions themselves display a success depsite the errors. Can we fix that or is it required by the integration somehow ?

ocots commented 2 months ago

There is a failure since OC need CTBase.jl 0.12. It is normal.

The check can be ok even if there is a failure since the check is for merging. The failure indicates that there is something to change in OC.

ocots commented 2 months ago

@PierreMartinon Avant de merge cette PR, il faudrait merge celle-ci : https://github.com/control-toolbox/CTDirect.jl/pull/218

Attention, https://github.com/control-toolbox/CTDirect.jl/pull/218 merge dans la branche ctbase0.13. C'est juste un formattage du code. Je suis en train d'ajouter un formattage automatique sur tous les repos.

ocots commented 2 months ago

@PierreMartinon Tu veux pas la merge ?

PierreMartinon commented 2 months ago

@PierreMartinon Tu veux pas la merge ?

La 218 est faite, je suis en train de finir celle-ci