search

control4 / docs-driverworks

Home Page for the Driverworks SDK
Other
41 stars 17 forks source link

light_v2 proxy docs issues and questions #4

Open spike411 opened 3 years ago

spike411 commented 3 years ago

Light V2 Commands TOGGLE navigation link leads to Fan proxy

Light V2 Protocol Notifications BUTTON ACTION navigation link leads to Light V2 Commands BUTTON ACTION CLICK COUNT navigation link leads to Keypad proxy ONLINE CHANGED navigation link leads to Keypad proxy

Light V2 Variables navigation link does not work (or the section is empty) - I think the variables are mistakenly under (Light V2's) ONLINE CHANGED section.

I don't see the following proxy commands documented (based on my own testing with a skeleton/template driver and looking at knx_switch.c4i source code): LIGHT_LEVEL_CHANGED GET_LIGHT_LEVEL GET_CONNECTED_STATE SYNCHRONIZE ON OFF TOGGLE_PRESET PUSH_TOGGLE_BUTTON RELEASE_TOGGLE_BUTTON There should be some note (or a link to the proper section) about handling DO_PUSH, DO_RELEASE, DO_CLICK coming from BUTTON_LINK connections. CLEAR_ALL_SCENES PUSH_SCENE REMOVE_SCENE ALL_SCENES_PUSHED ACTIVATE_SCENE RAMP_SCENE_UP RAMP_SCENE_DOWN STOP_RAMP_SCENE

Are Advanced Lighting Scenes documented at all? What about light group commands? https://forums.control4.com/fb.aspx?m=496138

I don't see it mentioned anywhere in the docs - with switch (on/off) lights, should (must) LIGHT_LEVEL = 0 be used for the OFF state and LIGHT_LEVEL = 100 for the ON state?

I think that the light_v2 proxy with it being tied to or intertwined with the keypad proxy is a bit of a mess. BUTTON_ACTION and DO_PUSH et al. seem to overlap etc. Why do navigators send BUTTON_ACTION instead of simple ON, OFF, TOGGLE?

spike411 commented 3 years ago

What's with the "signature" C4:LIGHT_LEVEL ()? https://control4.github.io/docs-driverworks-proxyprotocol/#light-level The C4: prefix and () seem to suggest it's a function on its own but I'm getting attempt to call method 'LIGHT_LEVEL' (a nil value) when I try to call it from my code.

Shouldn't that be C4:SendToProxy(5001, 'LIGHT_LEVEL_CHANGED', 100 ) or C4:SendToProxy(5001, 'LIGHT_LEVEL', 100 )? I can see both in knx_switch.c4i, but only the latter version changes the UI state. Is LIGHT_LEVEL_CHANGED a bug in the KNX Switch driver?

spike411 commented 3 years ago

I'm thinking maybe I should have opened the issue under the correct component/project? https://github.com/control4/docs-driverworks-proxyprotocol

jmcgeeverC4 commented 3 years ago

The following have been resolved: Light V2 Commands TOGGLE navigation link leads to Fan proxy

Light V2 Protocol Notifications BUTTON ACTION navigation link leads to Light V2 Commands BUTTON ACTION CLICK COUNT navigation link leads to Keypad proxy ONLINE CHANGED navigation link leads to Keypad proxy

Light V2 Variables navigation link does not work (or the section is empty) - I think the variables are mistakenly under (Light V2's) ONLINE CHANGED section.

What's with the "signature" C4:LIGHT_LEVEL ()?

The remainder will need to be addressed with Engineering. I will reach out to them for clarification. Thanks for the feedback on the docs.

Webbeh commented 3 years ago

While we're at it, "DYNAMIC_CAPABILITIES_CHANGED" in the Light V2 API doesn't seem to work in any way.

It's documented on the github but isn't on the Driverworks API PDF (v3.1.3), but oddly enough was present in v3.1.2 PDFs.

The github documentation here has a typo (DYANAMIC instead of DYNAMIC), and, well, the UI doesn't respond at all to any kind of dynamic capability change. Tried to disable/enable the dimmer to no avail.

Any way to have a proper API call to enable/disable the dimmable capability whenever needed ?

Thank you !